Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip PRRL renewal on UNASSIGNED_SEQ_NO #44019

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Skip PRRL renewal on UNASSIGNED_SEQ_NO #44019

merged 1 commit into from
Jul 5, 2019

Commits on Jul 5, 2019

  1. Skip PRRL renewal on UNASSIGNED_SEQ_NO 

    Today when renewing PRRLs we assert that any invalid "backwards" renewals must
be because we are recovering the shard. In fact it's also possible to have
`checkpointState.globalCheckpoint == SequenceNumbers.UNASSIGNED_SEQ_NO` on a
tracked shard copy if the primary was just promoted and hasn't received
checkpoints from all of its peers too.

This commit weakens the assertion to match.

Caught by a [failure of the full cluster restart
tests](https://scans.gradle.com/s/5lllzgqtuegty/console-log#L8605)

Relates elastic#41536
    @DaveCTurner
    DaveCTurner committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    199ef03 View commit details
    Browse the repository at this point in the history