Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Amends data frame analytics resources, GET, and PUT API docs #44806

Merged
merged 8 commits into from
Jul 26, 2019

Conversation

szabosteve
Copy link
Contributor

This PR addresses the feedback in https://github.com/elastic/ml-team/issues/175#issuecomment-512215731.

  • Adds an example to analyzed_fields
  • Includes source and dest objects inline in the resource page
  • Lists model_memory_limit in the PUT API page
  • Amends the analysis section in the resource page
  • Removes Properties headings in subsections
  • Highlights that size, from, and allow_no_match could be path parameters, too

@szabosteve szabosteve added >docs General docs changes :ml Machine learning v8.0.0 :ml/Transform Transform v7.4.0 v7.3.1 labels Jul 24, 2019
@szabosteve szabosteve requested a review from lcawl July 24, 2019 11:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@szabosteve
Copy link
Contributor Author

Also extended the description of allow_no_match param and added a response code section via a8ee7ed. This makes #44498 unnecessary, so I close it.

@szabosteve szabosteve merged commit 8479347 into elastic:master Jul 26, 2019
@szabosteve szabosteve deleted the issue175 branch July 26, 2019 09:40
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Jul 26, 2019
…lastic#44806)

This PR addresses the feedback in  elastic/ml-team#175 (comment).

* Adds an example to `analyzed_fields`
* Includes `source` and `dest` objects inline in the resource page
* Lists `model_memory_limit` in the PUT API page
* Amends the `analysis` section in the resource page
* Removes Properties headings in subsections
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Jul 26, 2019
…lastic#44806)

This PR addresses the feedback in  elastic/ml-team#175 (comment).

* Adds an example to `analyzed_fields`
* Includes `source` and `dest` objects inline in the resource page
* Lists `model_memory_limit` in the PUT API page
* Amends the `analysis` section in the resource page
* Removes Properties headings in subsections
@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 26, 2019
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
…44806)

This PR addresses the feedback in  elastic/ml-team#175 (comment).

* Adds an example to `analyzed_fields`
* Includes `source` and `dest` objects inline in the resource page
* Lists `model_memory_limit` in the PUT API page
* Amends the `analysis` section in the resource page
* Removes Properties headings in subsections
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml/Transform Transform :ml Machine learning v7.3.0 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants