Fix the JVM we use for bwc nodes #46314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we would run bwc nodes with their bundled jdk if these supported it, so the passed in runtime JDK was not honored. This became obvius when running with FIPS. Closes elastic#41721
|
Pinging @elastic/es-core-infra |
pugnascotia
approved these changes
Sep 4, 2019
mark-vieira
approved these changes
Sep 4, 2019
|
Don't we always have runtime java home set in CI? Wouldn't this effectively eliminate testing of the bundled jdk? |
|
@rjernst yes, it will. I'll prioritize #40531 to fix that. The alternative is to make this fips specific here ( set JAVA_HOME if running in a fips jvm ). |
alpar-t
added a commit
that referenced
this pull request
Sep 9, 2019
Before this change we would run bwc nodes with their bundled jdk if these supported it, so the passed in runtime JDK was not honored. This became obvius when running with FIPS. Closes #41721
alpar-t
added a commit
that referenced
this pull request
Sep 9, 2019
Before this change we would run bwc nodes with their bundled jdk if these supported it, so the passed in runtime JDK was not honored. This became obvius when running with FIPS. Closes #41721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we would run bwc nodes with their bundled jdk if
these supported it, so the passed in runtime JDK was not honored.
This became obvius when running with FIPS.
Closes #41721