Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cache setting in UserAgentPlugin #46533

Merged
merged 4 commits into from
Sep 16, 2019

Conversation

spinscale
Copy link
Contributor

@spinscale spinscale commented Sep 10, 2019

The cache size setting was not registered. Also documentation has been added.

Review note: I think merging to master/7.x is fine, please veto if you disagree.

The setting was not registered. Also documentation has been added.
@dliappis dliappis added the :Core/Infra/Plugins Plugin API and infrastructure label Sep 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dliappis dliappis added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP and removed :Core/Infra/Plugins Plugin API and infrastructure labels Sep 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spinscale
Copy link
Contributor Author

@elasticmachine update branch

@spinscale
Copy link
Contributor Author

@elasticmachine update branch

@spinscale
Copy link
Contributor Author

@elasticmachine update branch

@spinscale
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/1

@spinscale spinscale merged commit 3cf99cf into elastic:master Sep 16, 2019
spinscale added a commit that referenced this pull request Sep 16, 2019
The setting was not registered. Also documentation has been added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants