Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML][Transforms] remove force flag from _start (#46414) #46748

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Sep 16, 2019

Backports the following commits to 7.x:

It no longer makes sense to include a force flag for our _start api.

If a failure occurs, a much safer path is to _stop?force=true and then call _start again. This allows for better clean up of resources and safer run-time guarantees.

The flag was not ever added to our docs or the HLRC.

* [ML][Transforms] remove `force` flag from _start

* fixing expected error message
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@benwtrent
Copy link
Member Author

run elasticsearch-ci/default-distro

@benwtrent benwtrent merged commit 9cf9c64 into elastic:7.x Sep 18, 2019
@benwtrent benwtrent deleted the backport/7.x/pr-46414 branch September 18, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants