Make ingest pipeline resolution logic unit testable #47026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted ingest pipeline resolution logic into a static method and added unit tests for pipeline resolution logic. Followup from elastic#46847
martijnvg
added
>non-issue
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features |
…eMatch test expected that MetaData#indices() is invoked instead of MetaData#getIndices() method. So changed the resolveRequiredOrDefaultPipeline(...) method to do this.
jasontedor
approved these changes
Sep 25, 2019
| indexRequest.isPipelineResolved(true); | ||
| } else if (IngestService.NOOP_PIPELINE_NAME.equals(indexRequest.getPipeline()) == false) { | ||
| boolean indexRequestHasPipeline = resolveRequiredOrDefaultPipeline(actionRequest, indexRequest, metaData); | ||
| if (indexRequestHasPipeline) { | ||
| hasIndexRequestsWithPipelines = true; |
There was a problem hiding this comment.
Maybe replace all of this with hasIndexRequestWithPipelines |= indexRequestHasPipeline. This will short-circuit if hasIndexRequestWithPipelines is already true and the branch predictor will love it. I would suggest that we leave a comment that resolveRequiredOrDefaultPipeline mutates indexRequest so that the method call can not be folded into the expression (we have to evaluate it).
There was a problem hiding this comment.
I hate that we mutate like this by the way, but it is what it is for now. 🤷♀
There was a problem hiding this comment.
yeah... not very clean 🤷♂
martijnvg
added a commit
that referenced
this pull request
Sep 25, 2019
Extracted ingest pipeline resolution logic into a static method and added unit tests for pipeline resolution logic. Followup from #46847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted ingest pipeline resolution logic into a static method
and added unit tests for pipeline resolution logic.
Followup from #46847