Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update painless-statements with if/else example #47485

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Update painless-statements with if/else example #47485

merged 1 commit into from
Oct 3, 2019

Conversation

renshuki
Copy link
Contributor

@renshuki renshuki commented Oct 3, 2019

I struggled to find a conditional statement (if/else) in the Painless documentation. I think it would be nice to at least have one here.

There is also the possibility to add somethig similar to A Brief Painless Walkthrough but this is less generic.

Thanks.

@ywelsch ywelsch added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes labels Oct 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig requested a review from rjernst October 3, 2019 12:57
jrodewig
jrodewig approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait until a dev has a chance to review before merging.

Note: If we add this example, it probably makes sense to add other examples (such as while).

jdconrad
jdconrad approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this.

@jrodewig jrodewig merged commit 960647a into 7.4 Oct 3, 2019
@jrodewig jrodewig deleted the renshuki-painless-statements-update branch October 3, 2019 19:22
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
2288052
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
dc02868
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
e427bf7
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
139c930
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
20e9a5e
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
f5ecfa4
jrodewig pushed a commit that referenced this pull request Oct 3, 2019
@renshuki @jrodewig
[DOCS] Update painless statements with if/else example (#47485)
8ef35aa
@renshuki
Copy link
Contributor Author

renshuki commented Oct 4, 2019

Awesome, thanks for the quick merge.
Noted I'll work on adding other statements to the doc as well @jrodewig

@renshuki renshuki mentioned this pull request Oct 23, 2019
Merged
jdconrad pushed a commit that referenced this pull request May 11, 2020
@renshuki
[DOCS] Add more examples to Painless statements (#48397)
f281684 
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request May 11, 2020
@renshuki @jdconrad
[DOCS] Add more examples to Painless statements (elastic#48397)
c0223de 
Add more examples to the Painless statements documentation (including while and do...while) as requested in elastic#47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
@renshuki @jdconrad
[DOCS] Add more examples to Painless statements (#48397)
0f54fe0 
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
@renshuki @jdconrad
[DOCS] Add more examples to Painless statements (#48397)
1ee9953 
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
@renshuki @jdconrad
[DOCS] Add more examples to Painless statements (#48397)
9f7c5c7 
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
@renshuki @jdconrad
[DOCS] Add more examples to Painless statements (#48397)
b90c7e3 
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
@renshuki @jdconrad
[DOCS] Add more examples to Painless statements (#48397)
a6b4a43 
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdconrad jdconrad jdconrad approved these changes

@jrodewig jrodewig jrodewig approved these changes

@rjernst rjernst Awaiting requested review from rjernst

Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v6.8.4 v7.0.2 v7.1.2 v7.2.2 v7.3.3 v7.4.1 v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renshuki @elasticmachine @jdconrad @jrodewig @jakelandis @ywelsch