Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slices to delete and update by query in HLRC #48420

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Oct 23, 2019

The slices param was missing from both delete by query and update by
query in the HLRC request converters. This commit fixes the omission.

The slices param was missing from both delete by query and update by
query in the HLRC request converters. This commit fixes the omission.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hub-cap
Copy link
Contributor Author

hub-cap commented Oct 24, 2019

@elasticmachine run elasticsearch-ci/bwc

@hub-cap
Copy link
Contributor Author

hub-cap commented Oct 25, 2019

@elasticmachine update branch

@hub-cap hub-cap merged commit 27c1902 into elastic:master Oct 25, 2019
@hub-cap hub-cap deleted the hlrc_slices branch October 25, 2019 20:22
hub-cap added a commit that referenced this pull request Oct 25, 2019
The slices param was missing from both delete by query and update by
query in the HLRC request converters. This commit fixes the omission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants