[Transform] do not fail checkpoint creation due to global checkpoint mismatch #48423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
benwtrent
approved these changes
Oct 23, 2019
| // it's possible that replica shards report a different/higher global checkpoints | ||
| // This is by design and not a problem, take the max() for this case | ||
| if (checkpoints.get(shard.getShardRouting().getId()) < globalCheckpoint) { | ||
| checkpoints.put(shard.getShardRouting().getId(), globalCheckpoint); |
There was a problem hiding this comment.
this whole if clause could then be changed to something similar to
checkpoints.compute(shard.getShardRouting().getId(), (shardId, cp) -> (cp == null) ? globalCheckpoint : Math.max(cp, globalCheckPoint))
hendrikmuhs
force-pushed
the
transform-globalcp-max
branch
from
ae7d3ad
to
1a2cb53
Compare
|
run elasticsearch-ci/1 |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the max if global checkpoints mismatch instead of throwing an exception. It turned out global
checkpoints can mismatch by design
fixes #48379
Severity: checkpoint creation can fail due to this issue in rare cases, however checkpoint creation is retried