-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preflight check to dynamic mapping updates #48817
Merged
DaveCTurner
merged 8 commits into
elastic:master
from
DaveCTurner:2019-11-01-preflight-mapping-updates
Nov 5, 2019
Merged
Add preflight check to dynamic mapping updates #48817
DaveCTurner
merged 8 commits into
elastic:master
from
DaveCTurner:2019-11-01-preflight-mapping-updates
Nov 5, 2019
Commits on Nov 1, 2019
-
Add preflight check to dynamic mapping updates
Today if the primary discovers that an indexing request needs a mapping update then it will send it to the master for validation and processing. If, however, the put-mapping request is invalid then the master still processes it as a (no-op) cluster state update. When there are a large number of indexing operations that result in invalid mapping updates this can overwhelm the master. However, the primary already has a reasonably up-to-date mapping against which it can check the (approximate) validity of the put-mapping request before sending it to the master. For instance it is not possible to remove fields in a mapping update, so if the primary detects that a mapping update will exceed the fields limit then it can reject it itself and avoid bothering the master. This commit adds a pre-flight check to the mapping update path so that the primary can discard obviously-invalid put-mapping requests itself. Fixes elastic#35564
Configuration menu - View commit details
-
Copy full SHA for 1e3983c - Browse repository at this point
Copy the full SHA 1e3983cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 148206d - Browse repository at this point
Copy the full SHA 148206dView commit details
Commits on Nov 3, 2019
-
Revert "Allow tests to override mapping validation"
This reverts commit 148206d.
Configuration menu - View commit details
-
Copy full SHA for 006a8bf - Browse repository at this point
Copy the full SHA 006a8bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b66099 - Browse repository at this point
Copy the full SHA 4b66099View commit details
Commits on Nov 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 82e6010 - Browse repository at this point
Copy the full SHA 82e6010View commit details -
Configuration menu - View commit details
-
Copy full SHA for 891e56a - Browse repository at this point
Copy the full SHA 891e56aView commit details
Commits on Nov 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 21f9fb0 - Browse repository at this point
Copy the full SHA 21f9fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fdfbd7 - Browse repository at this point
Copy the full SHA 1fdfbd7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.