Fix X-Pack SchedulerEngine Shutdown #48951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can have a race here where `scheduleNextRun` executes concurrently to `stop` and so we run into a `RejectedExecutionException` that we don't catch and thus it fails tests. => Fixed by ignoring these so long as they coincide with a scheduler shutdown
|
Pinging @elastic/es-core-features (:Core/Features/Features) |
|
Thanks Jake! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 13, 2019
We can have a race here where `scheduleNextRun` executes concurrently to `stop` and so we run into a `RejectedExecutionException` that we don't catch and thus it fails tests. => Fixed by ignoring these so long as they coincide with a scheduler shutdown
original-brownbear
added a commit
that referenced
this pull request
Nov 13, 2019
We can have a race here where `scheduleNextRun` executes concurrently to `stop` and so we run into a `RejectedExecutionException` that we don't catch and thus it fails tests. => Fixed by ignoring these so long as they coincide with a scheduler shutdown
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have a race here where
scheduleNextRunexecutes concurrently tostopand so we run into a
RejectedExecutionExceptionthat we don't catch and thus itfails tests.
=> Fixed by ignoring these so long as they coincide with a scheduler shutdown
example failure: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/10376/testReport/junit/org.elasticsearch.xpack.watcher.test.integration/HttpSecretsIntegrationTests/classMethod/