Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout while checking for no snapshotted commit #49461

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 21, 2019

If some replica is performing a file-based recovery, then the check assertNoSnapshottedIndexCommit would fail. We should increase the timeout for this check so that we can wait until all recoveries done or aborted.

Closes #49403

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v7.6.0 v7.4.3 v6.8.6 v7.5.1 labels Nov 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

@dnhatn dnhatn requested a review from ywelsch November 22, 2019 13:41
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit 5d00bee into elastic:master Nov 22, 2019
@dnhatn dnhatn deleted the increase-timeout-check-snapshot branch November 22, 2019 13:51
@dnhatn
Copy link
Member Author

dnhatn commented Nov 22, 2019

Thanks Yannick.

dnhatn added a commit that referenced this pull request Nov 24, 2019
If some replica is performing a file-based recovery, then the check 
assertNoSnapshottedIndexCommit would fail. We should increase the
timeout for this check so that we can wait until all recoveries done
or aborted.

Closes #49403
dnhatn added a commit that referenced this pull request Nov 24, 2019
If some replica is performing a file-based recovery, then the check 
assertNoSnapshottedIndexCommit would fail. We should increase the
timeout for this check so that we can wait until all recoveries done
or aborted.

Closes #49403
dnhatn added a commit that referenced this pull request Nov 24, 2019
If some replica is performing a file-based recovery, then the check 
assertNoSnapshottedIndexCommit would fail. We should increase the
timeout for this check so that we can wait until all recoveries done
or aborted.

Closes #49403
dnhatn added a commit that referenced this pull request Nov 25, 2019
If some replica is performing a file-based recovery, then the check 
assertNoSnapshottedIndexCommit would fail. We should increase the
timeout for this check so that we can wait until all recoveries done
or aborted.

Closes #49403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests v6.8.6 v7.4.3 v7.5.1 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure in CloseWhileRelocatingShardsIT
4 participants