-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout while checking for no snapshotted commit #49461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Issues or PRs that are addressing/adding tests
:Distributed/Recovery
Anything around constructing a new shard, either from a local or a remote source.
v8.0.0
v7.6.0
v7.4.3
v6.8.6
v7.5.1
labels
Nov 21, 2019
Pinging @elastic/es-distributed (:Distributed/Recovery) |
ywelsch
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Yannick. |
dnhatn
added a commit
that referenced
this pull request
Nov 24, 2019
If some replica is performing a file-based recovery, then the check assertNoSnapshottedIndexCommit would fail. We should increase the timeout for this check so that we can wait until all recoveries done or aborted. Closes #49403
dnhatn
added a commit
that referenced
this pull request
Nov 24, 2019
If some replica is performing a file-based recovery, then the check assertNoSnapshottedIndexCommit would fail. We should increase the timeout for this check so that we can wait until all recoveries done or aborted. Closes #49403
dnhatn
added a commit
that referenced
this pull request
Nov 24, 2019
If some replica is performing a file-based recovery, then the check assertNoSnapshottedIndexCommit would fail. We should increase the timeout for this check so that we can wait until all recoveries done or aborted. Closes #49403
dnhatn
added a commit
that referenced
this pull request
Nov 25, 2019
If some replica is performing a file-based recovery, then the check assertNoSnapshottedIndexCommit would fail. We should increase the timeout for this check so that we can wait until all recoveries done or aborted. Closes #49403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed/Recovery
Anything around constructing a new shard, either from a local or a remote source.
>test
Issues or PRs that are addressing/adding tests
v6.8.6
v7.4.3
v7.5.1
v7.6.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some replica is performing a file-based recovery, then the check
assertNoSnapshottedIndexCommit
would fail. We should increase the timeout for this check so that we can wait until all recoveries done or aborted.Closes #49403