Make docker build task incremental #49613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits sets an output marker file for the docker build tasks so that it can be tracked as up to date. It also fixes the docker build context task to omit the build date as in input property which always left the task as out of date. relates elastic#49359
rjernst
added
>enhancement
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
pugnascotia
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
+1000, I love this PR!
One suggestion - can we also set the export tasks outputs? E.g.
diff --git a/distribution/docker/build.gradle b/distribution/docker/build.gradle
index 975c32860e1..da940f17b0f 100644
--- a/distribution/docker/build.gradle
+++ b/distribution/docker/build.gradle
@@ -214,6 +214,7 @@ subprojects { Project subProject ->
final Task exportDockerImageTask = task(exportTaskName, type: LoggedExec) {
executable 'docker'
+ outputs.file(tarFile)
args "save",
"-o",
tarFile,
rjernst
added a commit
that referenced
this pull request
Nov 28, 2019
This commits sets an output marker file for the docker build tasks so that it can be tracked as up to date. It also fixes the docker build context task to omit the build date as in input property which always left the task as out of date. relates #49359
|
This change does indeed make the build tasks |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 4, 2019
The docker build task depends on the docker context being built, but it was not explicitly setup as an input. This commit adds the task as an input to the docker build. relates elastic#49613
rjernst
added a commit
that referenced
this pull request
Dec 4, 2019
The docker build task depends on the docker context being built, but it was not explicitly setup as an input. This commit adds the task as an input to the docker build. relates #49613
rjernst
added a commit
that referenced
this pull request
Dec 4, 2019
The docker build task depends on the docker context being built, but it was not explicitly setup as an input. This commit adds the task as an input to the docker build. relates #49613
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The docker build task depends on the docker context being built, but it was not explicitly setup as an input. This commit adds the task as an input to the docker build. relates elastic#49613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits sets an output marker file for the docker build tasks so
that it can be tracked as up to date. It also fixes the docker build
context task to omit the build date as in input property which always
left the task as out of date.
Closes #49359