Fix concurrent issue in SearchPhaseController #49829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list used by the search progress listener can be nullified by another thread that reports a query result. This change replaces the usage of this list with a new array that is synchronously modified. Closes elastic#49778
jimczi
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
added a commit
that referenced
this pull request
Dec 5, 2019
The list used by the search progress listener can be nullified by another thread that reports a query result. This change replaces the usage of this list with a new array that is synchronously modified. Closes #49778
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The list used by the search progress listener can be nullified by another thread that reports a query result. This change replaces the usage of this list with a new array that is synchronously modified. Closes elastic#49778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list used by the search progress listener can be nullified by another thread that
reports a query result. This change replaces the usage of this list with a new array that is synchronously modified.
I tagged this pr with non-issue because it only affects master and 7.x, all non-released branches.
Closes #49778