Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingest simulate response document order if processor executes async #50244

Merged

Commits on Dec 16, 2019

  1. Fix ingest simulate response document order if processor executes async

    If a processor executes asynchronously and the ingest simulate api simulates with
    multiple documents then the order of the documents in the response may not match
    the order of the documents in the request.
    
    Alexander Reelsen discovered this issue with the enrich processor with the following reproduction:
    
    ```
    PUT cities/_doc/munich
    {"zip":"80331","city":"Munich"}
    
    PUT cities/_doc/berlin
    {"zip":"10965","city":"Berlin"}
    
    PUT /_enrich/policy/zip-policy
    {
      "match": {
        "indices": "cities",
        "match_field": "zip",
        "enrich_fields": [ "city" ]
      }
    }
    
    POST /_enrich/policy/zip-policy/_execute
    
    GET _cat/indices/.enrich-*
    
    POST /_ingest/pipeline/_simulate
    {
      "pipeline": {
      "processors" : [
        {
          "enrich" : {
            "policy_name": "zip-policy",
            "field" : "zip",
            "target_field": "city",
            "max_matches": "1"
          }
        }
      ]
      },
      "docs": [
        { "_id": "first", "_source" : { "zip" : "80331" } } ,
        { "_id": "second", "_source" : { "zip" : "50667" } }
      ]
    }
    ```
    martijnvg committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    792a8a6 View commit details
    Browse the repository at this point in the history
  2. rename

    martijnvg committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    e024dcf View commit details
    Browse the repository at this point in the history
  3. fixed code formatting and

    added comment
    martijnvg committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    0228225 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. added timeout

    martijnvg committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    40676bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    608980a View commit details
    Browse the repository at this point in the history