Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom metadata tool #50813

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jan 9, 2020

Adds a command-line tool to remove broken custom metadata from the cluster state.

Relates to #48701

@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 10, 2020

@elasticmachine run elasticsearch-ci/2

@ywelsch ywelsch added :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >enhancement labels Jan 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

@ywelsch ywelsch marked this pull request as ready for review January 10, 2020 09:02
@ywelsch ywelsch changed the base branch from reduce-metadata-writes-master to master January 14, 2020 11:56
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments/questions on UX & docs but nothing major.

@ywelsch ywelsch merged commit d94b81e into elastic:master Jan 14, 2020
ywelsch added a commit that referenced this pull request Jan 14, 2020
Bad interaction with other recently merged PR.
ywelsch added a commit that referenced this pull request Jan 14, 2020
Adds a command-line tool to remove broken custom metadata from the cluster state.

Relates to #48701
@raf64flo
Copy link

Hi, only a minor remark related to the title of this PR as well as in #50694 both of which appear in blog notes (https://www.elastic.co/blog/this-week-in-elasticsearch-and-apache-lucene-2020-01-17), I find them ambiguous and would find a naming like below better:

Tool to remove custom metadata

Anyway, thanks for that!

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Adds a command-line tool to remove broken custom metadata from the cluster state.

Relates to elastic#48701
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Bad interaction with other recently merged PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >enhancement v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants