Use standard format for reload settings API #51560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reload-secure-settings API page was not reorganized for the standard API format, so this commit is reorganizing the page and adding some links to the page in related documentation.
williamrandolph
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-security (:Security/Security) |
|
Note: these docs were originally written in #45054. |
jkakavas
reviewed
Jan 29, 2020
lcawl
reviewed
Jan 31, 2020
| ==== {api-request-title} | ||
| `POST _nodes/reload_secure_settings` + | ||
|
|
||
| `POST _nodes/nodeId1,nodeId2/reload_secure_settings` + |
There was a problem hiding this comment.
This should line up with the path parameter section:
Suggested change
| `POST _nodes/nodeId1,nodeId2/reload_secure_settings` + | |
| `POST _nodes/<nodes>/reload_secure_settings` + |
lcawl
reviewed
Jan 31, 2020
|
|
||
| `POST _nodes/nodeId1,nodeId2/reload_secure_settings` + | ||
|
|
||
| `POST _nodes/_local/reload_secure_settings` |
There was a problem hiding this comment.
I think this can be omitted since it's just another example of a value and it's mentioned in the link from the path parameters section.
lcawl
reviewed
Jan 31, 2020
|
|
||
| `<nodes>`:: | ||
| (Optional, string) The names of particular nodes in the cluster to target. | ||
| For example, you may also selectively target `nodeId1` and `nodeId2`. The |
There was a problem hiding this comment.
Suggested change
| For example, you may also selectively target `nodeId1` and `nodeId2`. The | |
| For example, `nodeId1,nodeId2`. The |
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Feb 3, 2020
* Use standard format for reload settings API The reload-secure-settings API page was not reorganized for the standard API format, so this commit is reorganizing the page and adding some links to the page in related documentation. * Fix broken links * Reorder examples to correctly check API response * Note that only certain settings are reloadable * [DOCS] Edits layout * [DOCS] Removes unnecessary callouts Co-authored-by: Lisa Cawley <[email protected]>
williamrandolph
added a commit
that referenced
this pull request
Feb 3, 2020
* Use standard format for reload settings API The reload-secure-settings API page was not reorganized for the standard API format, so this commit is reorganizing the page and adding some links to the page in related documentation. * Fix broken links * Reorder examples to correctly check API response * Note that only certain settings are reloadable * [DOCS] Edits layout * [DOCS] Removes unnecessary callouts Co-authored-by: Lisa Cawley <[email protected]> Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reload-secure-settings API page was not reorganized for the standard
API format, so this commit is reorganizing the page and adding some
links to the page in related documentation.
This is a follow-up to #51123 .
Preview: http://elasticsearch_51560.docs-preview.app.elstc.co/diff