Remove constant folding in Painless user tree #52783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
|
Relates to #49869 |
|
@rjernst @stu-elastic Thanks for the reviews! |
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes constant folding from the Painless user tree. This accomplishes two goals. The first is to remove all optimizations from the user tree which will at a later time become optimization phases for the ir tree. The second is to make the user tree immutable, and this is a step toward that since we will no longer remove/modify/replace nodes in the user tree during the process of constant folding.
One important note is that the conditional promotion code has changed, since the promoteConditional method considered constants (similarly to the JVM spec) that are now removed, but this code path was unreachable to begin with so the constants were never actually used to determine the appropriate promotion.