Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead 'beats' code #53312

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

jakelandis
Copy link
Contributor

@jakelandis jakelandis commented Mar 9, 2020

It appears that at one point beats central config was
intended to be managed by Elasticsearch. While the (basic) license
is indeed managed, the enable/disable and usage information
was never implemented.

This PR removes the parts of the code that were never implemented.

related #30520

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Features)

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelandis jakelandis merged commit 2b96a6b into elastic:master Mar 10, 2020
@jakelandis jakelandis deleted the remove_dead_beats_code branch March 10, 2020 23:02
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Mar 11, 2020
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Mar 11, 2020
@jakelandis jakelandis removed the v7.6.2 label Mar 11, 2020
@jakelandis
Copy link
Contributor Author

There is a slim chance that someone, somewhere stumbled upon the undocumented setting that did nothing (removed with this PR) and included it in some workflow. For this reason, I decided not to merge the removal back to the last patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants