Wait for ES to be green before deleting configs #53437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing manual creation of a keystore in Docker fails unpredictably on 7.6, possibly indicating a problem with deleting the keystore file at a particular moment during Elasticsearch startup. In order to cut this Gordian Knot, we should just wait for Elasticsearch to become green before messing around with files that it needs for startup. I'm also backporting a change to how we check whether ES is running. It doesn't seem to be a problem with this test, but I think it's more reliable.
williamrandolph
added
>non-issue
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
|
@jaymode Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing manual creation of a keystore in Docker fails unpredictably on
7.6, possibly indicating a problem with deleting the keystore file
at a particular moment during Elasticsearch startup. In order to cut
this Gordian Knot, we should just wait for Elasticsearch to become green
before messing around with files that it needs for startup.
I'm also backporting a change to how we check whether ES is running. It
doesn't seem to be a problem with this test, but I think it's more
reliable. This got into 7.7 and master via #50610.
Closes #51316