-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit deprecation warning when TermsLookup contains a type #53731
Merged
romseygeek
merged 16 commits into
elastic:7.x
from
romseygeek:deprecation/termslookup-7x
Mar 20, 2020
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
32d4652
Emit deprecation warning when TermsLookup contains a type
romseygeek 9ffe713
Check warnings in YAML tests
romseygeek b83ec59
precommit
romseygeek 0e49083
tests; termsquery doesn't need extra warnings
romseygeek aa7fa91
precommit
romseygeek 41b7247
BWC filtering
romseygeek 500fc61
Allow for BWC tests against 6x
romseygeek 87c1cfe
yml
romseygeek ce72cb3
Merge remote-tracking branch 'origin/7.x' into deprecation/termslooku…
romseygeek 64602aa
Used allowed_warnings instead of skipping
romseygeek 84b6890
skip allowed_warnings
romseygeek fddd002
Merge branch '7.x' into deprecation/termslookup-7x
romseygeek c7a5f4e
Merge branch '7.x' into deprecation/termslookup-7x
romseygeek 8cbbc2d
tests
romseygeek ff32c3f
precommit
romseygeek 4a2bb3c
re-add skip parameters
romseygeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romseygeek sorry for the late review, I'm wondering why this check wasn't sufficient for emitting a deprecation warning? Was it not triggered on all the relevant code paths?
It would be nice to keep this strategy if possible, since it's consistent with all our other types deprecation warnings (
deprecatedAndMaybeLog("api_name_with_types", TYPES_DEPRECATION_MESSAGE);
). It also lets us avoid adding anallowed_warnings
section to the yml tests, since in 7.x we already ignore all warnings in yml tests that start with[types removal] ...
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a path that didn't trigger the warning, but I can't find it now, so it may have been refactored away elsewhere. I'll have a look, it would be good to remove some of these extra
allowed_warnings
messages.