Upgrade to AWS SDK 1.11.749 #53962
Merged
Upgrade to AWS SDK 1.11.749 #53962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading AWS SDK to v1.11.749. Required building clients inside privileged contexts because some class loading that requires privileges now happens there and working around a new SDK bug in the S3 client builder. Closes elastic#53191
original-brownbear
added
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
Mar 23, 2020
| if ((endpoint.startsWith("http://") || endpoint.startsWith("https://")) == false) { | ||
| // Manually add the schema to the endpoint to work around https://github.com/aws/aws-sdk-java/issues/2274 | ||
| // TODO: Remove this once fixed in the AWS SDK | ||
| endpoint = clientSettings.protocol.toString() + "://" + endpoint; |
|
Thanks Tanguy! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 23, 2020
Upgrading AWS SDK to v1.11.749. Required building clients inside privileged contexts because some class loading that requires privileges now happens there and working around a new SDK bug in the S3 client builder. Closes elastic#53191
original-brownbear
added a commit
that referenced
this pull request
Mar 23, 2020
38 tasks
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 17, 2020
A recent AWS SDK upgrade has introduced a new source of spurious `WARN` logs when the security manager prevents access to the user's home directory and therefore to `$HOME/.aws/config`. This is the behaviour we want, and it's harmless and handled by the SDK as if the config doesn't exist, so this log message is unnecessary noise. This commit suppresses this noisy logging by default. Relates elastic#20313, elastic#56346, elastic#53962 Closes elastic#62493
DaveCTurner
added a commit
that referenced
this pull request
Sep 18, 2020
A recent AWS SDK upgrade has introduced a new source of spurious `WARN` logs when the security manager prevents access to the user's home directory and therefore to `$HOME/.aws/config`. This is the behaviour we want, and it's harmless and handled by the SDK as if the config doesn't exist, so this log message is unnecessary noise. This commit suppresses this noisy logging by default. Relates #20313, #56346, #53962 Closes #62493
DaveCTurner
added a commit
that referenced
this pull request
Sep 18, 2020
A recent AWS SDK upgrade has introduced a new source of spurious `WARN` logs when the security manager prevents access to the user's home directory and therefore to `$HOME/.aws/config`. This is the behaviour we want, and it's harmless and handled by the SDK as if the config doesn't exist, so this log message is unnecessary noise. This commit suppresses this noisy logging by default. Relates #20313, #56346, #53962 Closes #62493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading AWS SDK to v1.11.749.
Required building clients inside privileged contexts because some class loading that requires privileges now happens there
and working around a new SDK bug in the S3 client builder.
Closes #53191