Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casting of scaled_float in sorts #57207

Merged
merged 3 commits into from
May 29, 2020
Merged

Fix casting of scaled_float in sorts #57207

merged 3 commits into from
May 29, 2020

Commits on May 27, 2020

  1. Fix casting of scaled_float in sorts 

    Previously we'd get a `ClassCastException` when you tried to use
`numeric_type` on `scaled_float`. Oops! This cleans up the CCE and moves
some code around so the casting actually works.
    @nik9000
    nik9000 committed May 27, 2020
    Configuration menu
    Copy the full SHA
    572f090 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Explain why custom comparator

    @nik9000
    nik9000 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    d0b549c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_scaled_float_sort_casting

    @nik9000
    nik9000 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    42c9090 View commit details
    Browse the repository at this point in the history