Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how to determine if a field is metafield #57378

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Refactor how to determine if a field is metafield #57378

merged 5 commits into from
Jun 5, 2020

Commits on May 29, 2020

  1. Refactor how to determine if a field is metafield 

    Before to determine if a field is meta-field, a static method of MapperService
isMetadataField was used. This method was using an outdated static list
of meta-fields.

This PR instead changes this method to the instance method that
is also aware of meta-fields in all registered plugins.

Related elastic#38373, elastic#41656
Closes elastic#24422
    @mayya-sharipova
    mayya-sharipova committed May 29, 2020
    Configuration menu
    Copy the full SHA
    3de6272 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Address Christoph's feedback

    @mayya-sharipova
    mayya-sharipova committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    3a56fd2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge remote-tracking branch 'upstream/master' into metafield-refacto… 

    …ring
    @mayya-sharipova
    mayya-sharipova committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    a5a6b3f View commit details
    Browse the repository at this point in the history

  2. Correct AggregationsTests to exclude random fields from top_hits

    @mayya-sharipova
    mayya-sharipova committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b6d3364 View commit details
    Browse the repository at this point in the history

  3. Add comment to test: testDocumentParsingFailsOnMetaField

    @mayya-sharipova
    mayya-sharipova committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ac6a4bc View commit details
    Browse the repository at this point in the history