Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the 'array value parser' marker interface. #57622

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Remove the 'array value parser' marker interface. #57622

merged 1 commit into from
Jun 3, 2020
+35 −39

Commits on Jun 3, 2020

  1. Remove the 'array value parser' marker interface. (elastic#57571) 

    This PR replaces the marker interface with the method
FieldMapper#parsesArrayValue. I find this cleaner and it will help with the
fields retrieval work (elastic#55363).

The refactor also ensures that only field mappers can declare they parse array
values. Previously other types like ObjectMapper could implement the marker
interface and be passed array values, which doesn't make sense.
    @jtibshirani
    jtibshirani committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    2d29992 View commit details
    Browse the repository at this point in the history