Add support for a 'format' option in fields retrieval. #57855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
10 tasks
nik9000
approved these changes
Jun 9, 2020
|
|
||
| DateFormatter dateTimeFormatter = fieldType().dateTimeFormatter(); | ||
| if (format != null) { | ||
| dateTimeFormatter = DateFormatter.forPattern(format).withLocale(dateTimeFormatter.locale()); |
There was a problem hiding this comment.
I'd prefer to avoid this one day, but for now it is cool. And, I think it'd be a bit overboard to try and avoid it now. If I did want to avoid it maybe something like:
public Function<Object, String> sourceParser(String format);
I don't know. Just thinking out loud. Not needed now.
There was a problem hiding this comment.
I agree, instead of a function we could even introduce an object like SourceValueParser. This could also help clean up some of the fragility around the dual lookupValues and parseSourceValue methods. It did feel like overkill to do this refactor now, though.
|
Thanks @nik9000 for the review. Any thoughts on this comment?
|
I'm super ok doing it just for dates now. |
jtibshirani
added a commit
that referenced
this pull request
Jun 17, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jun 26, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jun 30, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jun 30, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jul 8, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jul 14, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jul 15, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jul 18, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jul 21, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
that referenced
this pull request
Jul 23, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Jul 27, 2020
The new `format` option allows for passing a custom date format:
```
POST logs-*/_search
{
"fields": [
"file.*",
{
"field": "event.timestamp",
"format": "epoch_millis"
},
...
]
}
```
Other API notes:
* We use the same syntax as `docvalue_fields` for consistency. Under the hood,
both `fields` and `docvalue_fields` use the same `FieldAndFormat` object to
share serialization logic.
* Only `date` and `date_range` fields support formatting currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
formatoption allows for passing a custom date format:Other API notes:
docvalue_fieldsfor consistency. Under the hood, bothfieldsanddocvalue_fieldsuse the sameFieldAndFormatobject to share serialization logic.dateanddate_rangefields support formatting currently. I really wasn't sure how helpful it was to support a decimal format on numeric fields (as we do withdocvalues_fields), and didn't want to add pre-emptive functionality. I'm very happy for feedback on this point.Implementation notes:
DocValueFormatto perform the formatting, but this didn't seem like the right way to go.DocValueFormatis specifically designed for translating between on-disk docvalues and human-readable values, and it felt like an abuse to start using it for formatting source values.