-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data frame analytics max_num_threads setting #59254
Merged
dimitris-athanasiou
merged 6 commits into
elastic:master
from
dimitris-athanasiou:df-analytics-max-number-threads
Jul 9, 2020
Merged
[ML] Data frame analytics max_num_threads setting #59254
dimitris-athanasiou
merged 6 commits into
elastic:master
from
dimitris-athanasiou:df-analytics-max-number-threads
Jul 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (:ml) |
I'll also add it in the YAML test after #59253 is merged |
benwtrent
reviewed
Jul 8, 2020
.../src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsConfigUpdate.java
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/ml/data_frame_analytics_crud.yml
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
changed the title
[ML] Data frame analytics max_number_threads setting
[ML] Data frame analytics max_num_threads setting
Jul 9, 2020
przemekwitek
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good, just a few wording nits.
docs/java-rest/high-level/ml/update-data-frame-analytics.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/ml/df-analytics/apis/update-dfanalytics.asciidoc
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a setting to data frame analytics jobs called `max_number_threads`. The setting expects a positive integer. When used the user specifies the max number of threads that may be used by the analysis. Note that the actual number of threads used is limited by the number of processors on the node where the job is assigned. Also, the process may use a couple more threads for operational functionality that is not the analysis itself. This setting may also be updated for a stopped job. More threads may reduce the time it takes to complete the job at the cost of using more CPU.
dimitris-athanasiou
force-pushed
the
df-analytics-max-number-threads
branch
from
July 9, 2020 13:01
776af53
to
9e5e9b4
Compare
12 tasks
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jul 9, 2020
Until elastic#59254 is backported to 7.x.
dimitris-athanasiou
added a commit
that referenced
this pull request
Jul 9, 2020
Until #59254 is backported to 7.x.
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jul 9, 2020
This adds a setting to data frame analytics jobs called `max_number_threads`. The setting expects a positive integer. When used the user specifies the max number of threads that may be used by the analysis. Note that the actual number of threads used is limited by the number of processors on the node where the job is assigned. Also, the process may use a couple more threads for operational functionality that is not the analysis itself. This setting may also be updated for a stopped job. More threads may reduce the time it takes to complete the job at the cost of using more CPU. Backport of elastic#59254 and elastic#57274
dimitris-athanasiou
added a commit
that referenced
this pull request
Jul 9, 2020
This adds a setting to data frame analytics jobs called `max_number_threads`. The setting expects a positive integer. When used the user specifies the max number of threads that may be used by the analysis. Note that the actual number of threads used is limited by the number of processors on the node where the job is assigned. Also, the process may use a couple more threads for operational functionality that is not the analysis itself. This setting may also be updated for a stopped job. More threads may reduce the time it takes to complete the job at the cost of using more CPU. Backport of #59254 and #57274
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jul 9, 2020
dimitris-athanasiou
added a commit
that referenced
this pull request
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a setting to data frame analytics jobs called
max_num_threads
. The setting expects a positive integer.When used the user specifies the max number of threads that may
be used by the analysis. Note that the actual number of threads
used is limited by the number of processors on the node where
the job is assigned. Also, the process may use a couple more threads
for operational functionality that is not the analysis itself.
This setting may also be updated for a stopped job.
More threads may reduce the time it takes to complete the job at the cost
of using more CPU.