Enforce fail on deprecated gradle usage #59598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
This seems reasonable. We already do updates as PRs to ensure nothing explodes. Seems trivial to remove any newly introduced deprecations as part of that work. |
|
yeah, Tackling depreciations as part of the Gradle update is IMO the best way to deal with them. |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 17, 2020
breskeby
added a commit
that referenced
this pull request
Jul 20, 2020
* Enforce fail on deprecated gradle usage (#59598) * Fix branch specific deprecated gradle api usages * Fix archiveVersion property usage
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 20, 2020
breskeby
added a commit
that referenced
this pull request
Jul 20, 2020
* Enforce fail on deprecated gradle usage (#59598) * Fix remaining gradle api deprecations
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 20, 2020
* Enforce fail on deprecated gradle usage (elastic#59598) * Fix remaining gradle api deprecations
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces the Gradle build to fail if a deprecated Gradle API was used in the build.
This guarantees us that we don't let deprecations sneak back into the build over time. A side effect of this though is, that when updating gradle versions, we need to tackle new deprecations as part of the update.