-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add double script fields #59933
Merged
nik9000
merged 8 commits into
elastic:feature/runtime_fields
from
nik9000:script_field_double
Jul 21, 2020
Merged
Add double script fields #59933
nik9000
merged 8 commits into
elastic:feature/runtime_fields
from
nik9000:script_field_double
Jul 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for `double` typed `script` fields.
nik9000
added
the
:Search/Search
Search-related issues that do not fall into other categories
label
Jul 20, 2020
Pinging @elastic/es-search (:Search/Search) |
javanna
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of suggestions for possible later improvements, LGTM though
.../src/main/java/org/elasticsearch/xpack/runtimefields/mapper/ScriptDoubleMappedFieldType.java
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/runtime_fields/30_double.yml
Show resolved
Hide resolved
...test/java/org/elasticsearch/xpack/runtimefields/mapper/ScriptDoubleMappedFieldTypeTests.java
Outdated
Show resolved
Hide resolved
30 tasks
Thanks @javanna ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
double
typedscript
fields.