Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using string 'y' in fields REST tests. #60471

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Avoid using string 'y' in fields REST tests. #60471

merged 1 commit into from
Jul 31, 2020

Conversation

jtibshirani
Copy link
Contributor

Some yaml parsers interpret 'y' and 'yes' as the boolean 'true'.

@jtibshirani
Avoid using string 'y' in fields REST tests.
a40b2be 
Some yaml parsers interpret 'y' and 'yes' as the boolean 'true'.
@jtibshirani jtibshirani added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Jul 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 30, 2020
@jtibshirani jtibshirani requested a review from karmi July 30, 2020 17:08
@jtibshirani jtibshirani mentioned this pull request Jul 30, 2020
Merged
@karmi
Copy link
Contributor

karmi commented Jul 31, 2020

Thanks!

javanna
javanna approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtibshirani jtibshirani merged commit 74b56f3 into elastic:master Jul 31, 2020
@jtibshirani jtibshirani deleted the fields-rest-tests branch July 31, 2020 16:09
jtibshirani added a commit that referenced this pull request Jul 31, 2020
@jtibshirani
Avoid using string 'y' in fields REST tests. (#60471)
fe1d877 
Some yaml parsers interpret 'y' and 'yes' as the boolean 'true'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmi karmi karmi approved these changes

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtibshirani @elasticmachine @karmi @javanna @jakelandis