Remove GCS Bucket Exists Check #60899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as elastic#43288 for GCS. We don't need to do the bucket exists check before using the repo, that just needlessly increases the necessary permissions for using the GCS repository.
original-brownbear
added
>non-issue
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
|
Thanks Yannick! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 10, 2020
Same as elastic#43288 for GCS. We don't need to do the bucket exists check before using the repo, that just needlessly increases the necessary permissions for using the GCS repository.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 10, 2020
Same as elastic#43288 for GCS. We don't need to do the bucket exists check before using the repo, that just needlessly increases the necessary permissions for using the GCS repository.
original-brownbear
added a commit
that referenced
this pull request
Aug 11, 2020
original-brownbear
added a commit
that referenced
this pull request
Aug 11, 2020
|
Thanks for implementing this! When it's released I hope we can finally only assign Do you know if it will make to the next 7.8.x release (if any)? |
|
Hey @haizaar no problem! I'm afraid this will only make it into 7.9.x though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #43288 for GCS.
We don't need to do the bucket exists check before using the repo, that just needlessly
increases the necessary permissions for using the GCS repository.
The change in what LIST API to use also reduces the number of API calls the SDK makes for each listing by one GET.
Slightly adjusted the way verification exceptions are handled also because the GCS SDK does throw
RuntimeExceptioninstead of anIOExceptionif a bucket does not exist and we should still bubble up aRepositoryExceptionin this case during verification I think.