Borrow more tests for runtime fields #61113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "borrows" 150 more tests from core for runtime fields, extending the work done in elastic#60931. More precisely, it adds a template to every test that forces dynamic mapping updates to build runtime fields where possible. In particular, `long` and `double` field are created as runtime fields. `string`-typed fields are mimick the out of the box behavior and create a top level `text` field with a `.keyword` multi-field, but this `keyword` multi-field executes a script and loads from source.
nik9000
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
javanna
approved these changes
Aug 14, 2020
| Map.entry("script", painlessToLoadFromSource("{name}", type)) | ||
| ); | ||
| Map<String, Object> body = Map.ofEntries( | ||
| Map.entry("match_mapping_type", type.equals("keyword") ? "string" : type), |
There was a problem hiding this comment.
what is string here? Is it the old field type string from before we had text and keyword?
There was a problem hiding this comment.
I think it is! Dynamic templates mostly uses the types that we use but it uses string instead of text or keyword.
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "borrows" 150 more tests from core for runtime fields, extending
the work done in #60931. More precisely, it adds a template to every
test that forces dynamic mapping updates to build runtime fields where
possible. In particular,
longanddoublefield are created asruntime fields.
string-typed fields are mimick the out of the boxbehavior and create a top level
textfield with a.keywordmulti-field, but this
keywordmulti-field executes a script and loadsfrom source.