Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for runtime field loops in queries (backport of #61927) #62421

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 15, 2020

We were checking for loops in queries before, but we had an "off by one"
error where we wouldn't notice the "top level" runtime field when
detecting a loop. So the error message would be wrong.

I also caught a few bugs with query generation caused by missing
@Override annotations and fixed a few of them. There is a bug with
regexp queries with match options that I'm not fixing in this PR but
will get to later.

Relates to #59332

We were checking for loops in queries before, but we had an "off by one"
error where we wouldn't notice the "top level" runtime field when
detecting a loop. So the error message would be wrong.

I also caught a few bugs with query generation caused by missing
`@Override` annotations and fixed a few of them. There is a bug with
`regexp` queries with match options that I'm not fixing in this PR but
will get to later.

Relates to elastic#59332
@nik9000 nik9000 merged commit e5ad3a4 into elastic:7.x Sep 15, 2020
@javanna javanna added v7.11.0 and removed v7.10.0 labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants