Add null-field checks to shape field mappers #71999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>non-issue
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
Marking as |
javanna
reviewed
Apr 21, 2021
| @@ -691,4 +691,16 @@ public final void testIndexTimeStoredFieldsAccess() throws IOException { | |||
| .fielddataBuilder("test", lookupSource) | |||
| .build(new IndexFieldDataCache.None(), new NoneCircuitBreakerService()); | |||
| } | |||
|
|
|||
| public final void testNullInput() throws Exception { | |||
| assumeTrue("Mapper does not permit null values", allowsNullValues()); | |||
There was a problem hiding this comment.
should we actually check that when the mapper does not allow null values, an exception is thrown?
There was a problem hiding this comment.
that's a good idea. I think I'm going to revert the changes to rank_features and dense_vectors as well and add them as TODOs because I want to get this into 7.13 and they should get some more discussion.
|
@javanna I updated the check to account for exception-throwing cases |
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Apr 21, 2021
elastic#71696 introduced a regression to the various shape field mappers, where they would no longer handle null values. This commit fixes that regression and adds a testNullValues method to MapperTestCase to ensure that all field mappers correctly handle nulls. Fixes elastic#71874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#71696 introduced a regression to the various shape field mappers,
where they would no longer handle null values. This commit fixes
that regression and adds a
testNullValuesmethod to MapperTestCaseto ensure that all field mappers correctly handle nulls.
Fixes #71874