Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sha256 header in elasticsearch RPMs #75569

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Add Sha256 header in elasticsearch RPMs #75569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions distribution/packages/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,23 @@ buildscript {
mavenCentral()
maven { url 'https://jitpack.io' }
}

// We rely on a patched version of the redline library used to build rpm packages
// to support sha256header in our elasticsearch RPMs
// TODO: Update / remove this dependency once https://github.com/craigwblake/redline/pull/157 got merged
// Be aware that it seems the redline project hasnt been active for a while
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we might end up forking it under an Elastic org?

configurations.all {
resolutionStrategy {
dependencySubstitution {
substitute module('org.redline-rpm:redline') using module('com.github.breskeby:redline:caa0ede')
}
}
}

dependencies {
classpath "com.github.breskeby:gradle-ospackage-plugin:98455c1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we're also using a patched version of the os-package plugin as well. Curiosity, what's that for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this hasn't been merged and released yet: nebula-plugins/gradle-ospackage-plugin#400

}

}

apply plugin: "nebula.ospackage-base"
Expand Down