Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resurrect _xpack/sql routes #75949

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Resurrect _xpack/sql routes #75949

merged 4 commits into from
Jan 14, 2022

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Aug 2, 2021 •
edited
Loading

Related to #51816 / #68905.

Adds back the _xpack/sql routes when using rest compatibility for a request.

@joegallo joegallo force-pushed the resurrect-xpack-sql-routes branch 2 times, most recently from 84beecc to 267d11e Compare August 10, 2021 20:46
@arteam arteam added v8.1.0 and removed v8.0.0 labels Jan 12, 2022
@joegallo joegallo added the Team:Clients Meta label for clients team label Jan 14, 2022
@joegallo joegallo marked this pull request as ready for review January 14, 2022 04:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@joegallo joegallo added Team:Clients Meta label for clients team :Core/Infra/REST API REST infrastructure and utilities and removed Team:Clients Meta label for clients team labels Jan 14, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 14, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@joegallo
Copy link
Contributor Author

Sorry for the label/comment noise, I was struggling trying to get the 'Check labels' CI bit to pass -- seems like the last bit finally did it.

jakelandis
jakelandis approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for following up on this !

sethmlarson
sethmlarson approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from lang-clients perspective

@joegallo joegallo merged commit d7d3485 into elastic:master Jan 14, 2022
@joegallo joegallo deleted the resurrect-xpack-sql-routes branch January 14, 2022 17:52
joegallo added a commit that referenced this pull request Jan 14, 2022
@joegallo
Re-enable deprecated _xpack/sql routes via REST compatibility (#75949)
a2dac35
@pugnascotia pugnascotia removed the v8.0.0 label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >non-issue Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team v8.0.0-rc2 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joegallo @elasticmachine @jakelandis @sethmlarson @arteam @pugnascotia @elasticsearchmachine