-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script: ulong via fields API #76519
Merged
stu-elastic
merged 16 commits into
elastic:master
from
stu-elastic:script/69742-06-ulong-as
Aug 17, 2021
Merged
Script: ulong via fields API #76519
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e8663a9
Script: ulong via fields API
stu-elastic f3f5700
Merge branch 'master' of github.com:elastic/elasticsearch into script…
stu-elastic 7adc6d4
Script: dense vector not implemented yet
stu-elastic 60ebf61
javadoc
stu-elastic 5155e51
Merge branch 'master' of github.com:elastic/elasticsearch into script…
stu-elastic 29dad53
don't cast EmptyField, create one
stu-elastic 4904abc
doc['ul'].value syntax
stu-elastic aa52c00
remove date tests
stu-elastic 2b1dc8a
date milli and nano tests
stu-elastic 69ec48d
remove unused TimeUnit
stu-elastic b5a2965
lenient big integer parsing
stu-elastic aef03a1
revert number parsing fanciness
stu-elastic e60fe36
pr comments
stu-elastic 5d82d1a
minimal UnsignedLongField.as(Field.Long) test
stu-elastic 5153221
unused import
stu-elastic 369e58b
format
stu-elastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
server/src/main/java/org/elasticsearch/script/Converter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
package org.elasticsearch.script; | ||
|
||
/** | ||
* Converts between one scripting {@link Field} type and another, {@code CF}, with a different underlying | ||
* value type, {@code CT}. | ||
*/ | ||
public interface Converter<CT, CF extends Field<CT>> { | ||
/** | ||
* Convert {@code sourceField} to a new field-type. Conversions come from user scripts so {@code covert} may | ||
* be called on a {@link Field}'s own type. | ||
*/ | ||
CF convert(Field<?> sourceField); | ||
|
||
/** | ||
* The destination {@link Field} class. | ||
*/ | ||
Class<CF> getFieldClass(); | ||
|
||
/** | ||
* The target value type. | ||
*/ | ||
Class<CT> getTargetClass(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe these should be
TC
for target class andFC
for Field class?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.