Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Update Painless Fields API design to use mapped types (#78950) #79201

Merged
merged 5 commits into from
Oct 18, 2021

Commits on Oct 14, 2021

  1. Update Painless Fields API design to use mapped types (elastic#78950)

    This change updates the Painless fields API to use mapped types instead of Java types. For this initial
    release we only support unsigned long field.
    
    As we now intend to do conversions solely on the field classes themselves, converters and field values
    have been removed. Instead of using field values potentially as source fallback we will now rely on
    whatever class is passed into the script to support the field method. In the future, this method will
    need to check if a field exists on doc and if not, then do source fallback itself once that feature is
    supported.
    
    The path to retrieve a field is also different. Instead of using script doc values we now have our own
    way to retrieve the fields with a getScriptField method added to LeafDocLookup. This allows us less
    restrictive design space to generate the field type based the type in the leaf doc lookup; however, this
    will still require additional information that we need to plumb through for certain field types. Once we
    support all the field types this makes it easier to deprecate and remove script doc values.
    jdconrad committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    149558d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b9640cd View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Configuration menu
    Copy the full SHA
    53c4990 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32c657f View commit details
    Browse the repository at this point in the history
  3. add comment to remove module

    jdconrad committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    1c3a7c2 View commit details
    Browse the repository at this point in the history