Java 17 instanceof pattern matching for test and x-pack/qa #82683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
astefan
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ywelsch
approved these changes
Jan 17, 2022
| @@ -206,8 +206,8 @@ public synchronized LoginContext login() throws PrivilegedActionException { | |||
| try { | |||
| return AccessController.doPrivileged((PrivilegedExceptionAction<T>) () -> Subject.doAsPrivileged(subject, action, acc)); | |||
| } catch (PrivilegedActionException pae) { | |||
| if (pae.getCause() instanceof PrivilegedActionException) { | |||
| throw (PrivilegedActionException) pae.getCause(); | |||
| if (pae.getCause()instanceof PrivilegedActionException privilegedActionException) { | |||
There was a problem hiding this comment.
reinstate space before instanceof
There was a problem hiding this comment.
@ywelsch unfortunately, that whitespace missing there is the result of spotless, because of a bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=574437. We are waiting for Spotless to fix it on their side: diffplug/spotless#1046.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Java 17
instanceofpattern matching for folderstestandx-pack/qa.