Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused CS Listener from SecurityServerTransportInterceptor #83556

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Feb 4, 2022

This listener only updated the value of an unused field => Removed it.

This listener only updated the value of an unsed field => Removed it.
@original-brownbear original-brownbear added >non-issue :Security/Client Security in clients (Transport, Rest) v8.2.0 labels Feb 4, 2022
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Feb 4, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@original-brownbear
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btw, the listener and variable became unused since #72300

@original-brownbear
Copy link
Member Author

Thanks Yang!

@original-brownbear original-brownbear merged commit fc793e1 into elastic:master Feb 7, 2022
@original-brownbear original-brownbear deleted the remove-unused-cs-listener branch February 7, 2022 07:37
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Feb 7, 2022
* upstream/master:
  [DOCS] Switch xrefs to external links (elastic#83590)
  [DOCS] 'features' flag added in elastic#83083 (elastic#83452)
  Rename ChangePolicyforIndexIT to ChangePolicyForIndexIT (elastic#83569)
  Fixing random_sampler tests (elastic#83549)
  Upgrade Checkstyle to 9.3 (elastic#83314)
  Make improvements to the release notes generator (elastic#83525)
  Cleanup DataTierAllocationDecider (elastic#83572)
  Upgrade jANSI dependency to 2.4.0 (elastic#83566)
  Speed up Name Collision Check in Metadata.Builder (elastic#83340)
  SQL: Add range checks to interval multiplication operation (elastic#83478)
  Remove DiscoveryNodes#getAllNodes (elastic#83538)
  Make RoutingNodes behave like a collection (elastic#83540)
  Remove Unused CS Listener from SecurityServerTransportInterceptor (elastic#83556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Security/Client Security in clients (Transport, Rest) Team:Security Meta label for security team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants