Added documentation on GeoJSON format for points and geo-points #86066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>docs
elasticmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
craigtaverner
force-pushed
the
geojson_point_docs
branch
2 times, most recently
from
653e73d
to
46f2c6c
Compare
|
@craigtaverner maybe it would be good to update this branch to get reviewed? |
And geo-points.
craigtaverner
force-pushed
the
geojson_point_docs
branch
from
46f2c6c
to
74d6ce7
Compare
craigtaverner
commented
Apr 26, 2022
| @@ -77,8 +77,9 @@ sorted list of `double` values. See | |||
| <<painless-runtime-double,double_field context>>. | |||
|
|
|||
| `geo_point_field`:: | |||
| The context for {ref}/geo-point.html[`geo-point` fields]. `emit` takes a | |||
| `geo-point` value and the script returns coordinates for the geo point. See | |||
| The context for {ref}/geo-point.html[`geo-point` fields]. `emit` takes two double | |||
There was a problem hiding this comment.
@iverase Could you verify this change. I think the old description seemed quite incorrect.
There was a problem hiding this comment.
I had a look and yes the explanation of the emit is correct, thanks! What it is not clear to me what we refer here to what the script returns. This is currently a bug as it should behave as an indexed geo_point which is not the case.
There was a problem hiding this comment.
Ok, this geo_point context is different to the out put of the fields API. lThe change looks good to me then.
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent work added support for GeoJSON to the following field types:
geo-pointSupport GeoJSON for geo_point #85120 (merged into 8.2.0)pointSupport 'GeoJSON' in CartesianPoint for 'point' #85442 (targeting 8.3.0)This PR provides documentation for these. Since this is based on the branch for cartesian point, it includes the commit from that branch. If that PR is merged first, then this PR will only contain the documentation commit. In either case the intention is to review only the documentation commit in this PR.