-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text field support in the Painless scripting fields API #89396
Conversation
Pinging @elastic/es-search (Team:Search) |
Hi @jdconrad, I've created a changelog YAML for you. |
@elasticmachine run elasticsearch-ci/part-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think that this change closes effectively the issue you linked. Thanks for working on this, it will make accessing text fields from a script much easier!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
@javanna @romseygeek Thank you both for the review! |
This change adds access to mapped text fields via the Painless scripting fields API. The values returned from a text field via the scripting fields API always use source as described by (#81246). Access via the old-style through doc will still depend on field data, so there is no change and avoids bwc issues.