Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source fallback support for match_only_text mapped type #89473

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

jdconrad
Copy link
Contributor

This change adds access to mapped match_only_text fields via the Painless scripting fields API. The values returned from a match_only_text field via the scripting fields API always use source as described by (#81246). These are not available via doc values so there are no bwc issues.

@jdconrad jdconrad added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v8.5.0 labels Aug 18, 2022
@jdconrad jdconrad requested a review from javanna August 18, 2022 17:42
@elasticsearchmachine
Copy link
Collaborator

Hi @jdconrad, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Aug 18, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jdconrad !

@javanna
Copy link
Member

javanna commented Aug 22, 2022

This one should close #81246 for real this time? :)

@jdconrad
Copy link
Contributor Author

@javanna Thanks for the review! I do believe it should indeed close #81246 for real this time :)

@jdconrad jdconrad merged commit 58fafe2 into elastic:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants