Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file.origin_referrer_url and file.origin_url to FileEvent #514

Merged
merged 10 commits into from
Jun 28, 2024

Conversation

AsuNa-jp
Copy link
Contributor

@AsuNa-jp AsuNa-jp commented Jun 27, 2024

Change Summary

This PR adds new file.origin_referrer_url and file.origin_url to the file event mapping. These fields will also be added to the ECS. (level: extended). The following is the ECS side PR.

To reviewers

Size of the fields
The two fields added in this PR are intended to store URL. Therefore, the default field size of 1024 bytes is insufficient. As a result, we want to set ignore_above to 8k bytes, if possible.

  • ignore_above: 8192

Default Field
This field will not necessarily be included in all file events.
Therefore, I set it as default_field: false, but please let me know if this is incorrect.

About windows_file_open.md

As a result of running make, process.command_line was added to windows_file_open.md. If this behavior is unexpected, please let me know.

Sample values

Release Target

8.15

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes

@AsuNa-jp AsuNa-jp self-assigned this Jun 27, 2024
@AsuNa-jp AsuNa-jp marked this pull request as ready for review June 27, 2024 10:36
@AsuNa-jp AsuNa-jp requested review from a team as code owners June 27, 2024 10:36
@pzl pzl requested review from pzl and removed request for gergoabraham and paul-tavares June 28, 2024 12:41
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no worries about the change in windows_file_open, maybe something was left behind in a previous PR? either way, things in custom_documentation have no ill-effect to the package functionality, so easy 👍 from me

will not necessarily be included in all file events.
Therefore, I set it as default_field: false

I don't believe that's what that setting does, but people doing fieldless-queries against our indices is probably rare, so no harm in using that setting anyway

  • can you add the sample data to package/endpoint/data_stream/file/sample_event.json ? Easy 👍 after that

@AsuNa-jp
Copy link
Contributor Author

Hi @pzl
Thank you very much for the review & feedback!
I added the sample data to package/endpoint/data_stream/file/sample_event.json !

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@AsuNa-jp AsuNa-jp enabled auto-merge (squash) June 28, 2024 13:07
@AsuNa-jp AsuNa-jp disabled auto-merge June 28, 2024 13:07
Copy link
Contributor

@intxgo intxgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not sure why these fields are being added there if they're going to be included in ECS

@AsuNa-jp AsuNa-jp merged commit faa42e5 into main Jun 28, 2024
4 checks passed
@AsuNa-jp AsuNa-jp deleted the add_8.15_filevents_fileds branch June 28, 2024 13:46
@elasticmachine
Copy link
Contributor

Package endpoint - 8.15.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants