[PR feedback] Types - is predicate rather than as casting

elastic · Aug 6, 2024 · 1ffb335 · 1ffb335
1 parent e3c779a
commit 1ffb335
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/...ui/src/components/selectable/selectable_templates/selectable_template_sitewide_option.tsx b/...ui/src/components/selectable/selectable_templates/selectable_template_sitewide_option.tsx
@@ -159,13 +159,15 @@ const renderOptionMeta = ({
         );
       }
 
+      const hasMetaTypeStyles = (
+        metaType: string
+      ): metaType is keyof typeof styles.metaTypes =>
+        metaType in styles.metaTypes;
+
       const cssStyles = [
         styles.euiSelectableTemplateSitewide__optionMeta,
-        ...(meta.type && meta.type in styles.metaTypes
-          ? [
-              styles.metaTypes.fontWeight,
-              styles.metaTypes[meta.type as keyof typeof styles.metaTypes],
-            ]
+        ...(meta.type && hasMetaTypeStyles(meta.type)
+          ? [styles.metaTypes.fontWeight, styles.metaTypes[meta.type]]
           : []),
       ];