Skip to content

Commit

Permalink
docs(storybook): PR feedback
Browse files Browse the repository at this point in the history
- removes skeleton in favor of string to ensure valid HTML

+ adds parent= on bottom bar to ensure last position on DOM updates
  • Loading branch information
mgadewoll committed Apr 10, 2024
1 parent 01892f4 commit 256c55c
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions src/components/page_template/page_template.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@ const headerContent = (
iconType="logoElastic"
pageTitle="Page title"
rightSideItems={[<EuiButton>Button</EuiButton>]}
description={
<EuiSkeletonText
lines={1}
contentAriaLabel="Page header example description"
/>
}
description="Page header example description"
tabs={[{ label: 'Tab 1', isSelected: true }, { label: 'Tab 2' }]}
/>
);
Expand Down Expand Up @@ -58,7 +53,9 @@ const sidebarContent = (
</EuiPageTemplate.Sidebar>
);
const bottomBarContent = (
<EuiPageTemplate.BottomBar paddingSize="s">
// adding parent="" here to prevent using a portal and to ensure the
// last position on changes when the parent does not change
<EuiPageTemplate.BottomBar paddingSize="s" parent="">
<EuiSkeletonText lines={1} contentAriaLabel="Bottom bar example text" />
</EuiPageTemplate.BottomBar>
);
Expand Down

0 comments on commit 256c55c

Please sign in to comment.