Move pagination react keys onto wrapping elements (#1514)

* Move pagination react keys onto wrapping elements * changelog
elastic · Feb 4, 2019 · 6eb3900 · 6eb3900
1 parent 83a6289
commit 6eb3900
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 **Bug fixes**
 
 - Updated `EuiPage` background color to match body background color ([#1513](https://github.com/elastic/eui/pull/1513))
+- Fixed React key usage in `EuiPagination` ([#1514](https://github.com/elastic/eui/pull/1514))
 
 ## [`6.8.0`](https://github.com/elastic/eui/tree/v6.8.0)
 

diff --git a/src/components/pagination/pagination.js b/src/components/pagination/pagination.js
@@ -67,13 +67,13 @@ export const EuiPagination = ({
   if (firstPageInRange > 0) {
     firstPageButtons.push(
       <EuiI18n
+        key="0"
         token="euiPagination.pageOfTotal"
         default="Page {page} of {total}"
         values={{ page: 1, total: lastPageInRange }}
       >
         {pageOfTotal => (
           <EuiPaginationButton
-            key="0"
             onClick={onPageClick.bind(null, 0)}
             hideOnMobile
             aria-label={pageOfTotal}
@@ -116,13 +116,13 @@ export const EuiPagination = ({
 
     lastPageButtons.push(
       <EuiI18n
+        key={pageCount - 1}
         token="euiPagination.jumpToLastPage"
         default="Jump to the last page, number {pageCount}"
         values={{ pageCount }}
       >
         {jumpToLastPage => (
           <EuiPaginationButton
-            key={pageCount - 1}
             onClick={onPageClick.bind(null, pageCount - 1)}
             hideOnMobile
             aria-label={jumpToLastPage}