Add viewBox attribute to SVG & JS logo icons where missing (#2240)

* Add `viewBox` attribute to SVG & JS logo icons where missing * Update unit test snapshots * Update changelog * Move changelog entry to `master`
elastic · Aug 21, 2019 · 718e59b · 718e59b
1 parent 0594cc1
commit 718e59b
Show file tree

Hide file tree

Showing 8 changed files with 27 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
-No public interface changes since `13.4.0`.
+**Bug fixes**
+
+- Added missing `viewBox` attribute to Docker, Kubernetes, and Redis logos ([#2240](https://github.com/elastic/eui/pull/2240))
 
 ## [`13.4.0`](https://github.com/elastic/eui/tree/v13.4.0)
 

diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap
@@ -3249,6 +3249,7 @@ exports[`EuiIcon props type logoDocker is rendered 1`] = `
   class="euiIcon euiIcon--medium euiIcon-isLoaded"
   focusable="false"
   height="32"
+  viewBox="0 0 32 32"
   width="32"
   xmlns="http://www.w3.org/2000/svg"
 >
@@ -3835,6 +3836,7 @@ exports[`EuiIcon props type logoKubernetes is rendered 1`] = `
   class="euiIcon euiIcon--medium euiIcon-isLoaded"
   focusable="false"
   height="32"
+  viewBox="0 0 32 32"
   width="32"
   xmlns="http://www.w3.org/2000/svg"
 >
@@ -4394,6 +4396,7 @@ exports[`EuiIcon props type logoRedis is rendered 1`] = `
   class="euiIcon euiIcon--medium euiIcon-isLoaded"
   focusable="false"
   height="32"
+  viewBox="0 0 32 32"
   width="32"
   xmlns="http://www.w3.org/2000/svg"
 >

diff --git a/src/components/icon/assets/logo_docker.js b/src/components/icon/assets/logo_docker.js
@@ -1,7 +1,12 @@
 import React from 'react';
 
 const EuiIconLogoDocker = props => (
-  <svg width={32} height={32} xmlns="http://www.w3.org/2000/svg" {...props}>
+  <svg
+    width={32}
+    height={32}
+    viewBox="0 0 32 32"
+    xmlns="http://www.w3.org/2000/svg"
+    {...props}>
     <path
       d="M18.099 15.108h3.304v-2.973H18.1v2.973zm-3.905 0h3.304v-2.973h-3.304v2.973zm-3.905 0h3.304v-2.973H10.29v2.973zm-3.905 0H9.69v-2.973H6.384v2.973zm-3.904 0h3.304v-2.973H2.48v2.973zm3.904-3.568H9.69V8.568H6.384v2.972zm3.905 0h3.304V8.568H10.29v2.972zm3.905 0h3.304V8.568h-3.304v2.972zm0-3.567h3.304V5h-3.304v2.973zm17.139 5.402c-.722-.478-2.38-.653-3.656-.415-.164-1.19-.834-2.221-2.052-3.153l-.7-.463-.468.694c-.598.893-.897 2.13-.8 3.317.045.418.183 1.164.617 1.82-.433.231-1.29.549-2.42.528H.124l-.043.247c-.204 1.193-.2 4.914 2.24 7.774C4.178 25.898 6.96 27 10.59 27c7.87 0 13.693-3.586 16.42-10.104 1.073.02 3.381.006 4.567-2.237.031-.051.102-.186.31-.61l.113-.234-.667-.44z"
       fill="#136EA3"

diff --git a/src/components/icon/assets/logo_docker.svg b/src/components/icon/assets/logo_docker.svg
diff --git a/src/components/icon/assets/logo_kubernetes.js b/src/components/icon/assets/logo_kubernetes.js
diff --git a/src/components/icon/assets/logo_kubernetes.svg b/src/components/icon/assets/logo_kubernetes.svg
diff --git a/src/components/icon/assets/logo_redis.js b/src/components/icon/assets/logo_redis.js
@@ -1,7 +1,12 @@
 import React from 'react';
 
 const EuiIconLogoRedis = props => (
-  <svg width={32} height={32} xmlns="http://www.w3.org/2000/svg" {...props}>
+  <svg
+    width={32}
+    height={32}
+    viewBox="0 0 32 32"
+    xmlns="http://www.w3.org/2000/svg"
+    {...props}>
     <g transform="translate(0 3)" fill="none">
       <path
         d="M30.594 20.791c-1.689.875-10.438 4.451-12.3 5.416-1.863.966-2.898.956-4.37.257-1.471-.699-10.782-4.437-12.46-5.234-.838-.399-1.278-.735-1.278-1.052v-3.18s12.121-2.623 14.078-3.32c1.957-.699 2.636-.724 4.301-.118 1.666.607 11.623 2.393 13.27 2.992l-.001 3.135c0 .314-.38.659-1.24 1.104z"