Skip to content

Commit

Permalink
Remove final low-usage $euiHeader Sass variables + delete remaining…
Browse files Browse the repository at this point in the history
… header scss files

- `$euiHeaderHeight` Sass variables have too much usage in Kibana etc., so keeping those for now - same for header Sass mixin
  • Loading branch information
cee-chen committed Jul 28, 2023
1 parent 90dedac commit 929f25a
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
Empty file removed src/components/header/_index.scss
Empty file.
1 change: 0 additions & 1 deletion src/components/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
@import 'drag_and_drop/index';
@import 'empty_prompt/index';
@import 'form/index';
@import 'header/index';
@import 'key_pad_menu/index';
@import 'markdown_editor/index';
@import 'notification/index';
Expand Down
6 changes: 0 additions & 6 deletions src/global_styling/variables/_header.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
// Themeable colors
$euiHeaderBackgroundColor: $euiColorEmptyShade !default;

// Layout vars
$euiHeaderHeight: $euiSizeXXL + $euiSizeS !default;
$euiHeaderChildSize: $euiSizeXXL !default;

// Use the following variable in other components to afford for the fixed header
$euiHeaderHeightCompensation: $euiHeaderHeight !default;
2 changes: 2 additions & 0 deletions upcoming_changelogs/7005.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@
- Converted `EuiHeaderAlert` to Emotion; Removed unused `.euiHeaderAlert__dismiss` CSS
- Converted `EuiHeaderSection`, `EuiHeaderSectionItem`, and `EuiHeaderSectionItemButton` to Emotion
- Converted `EuiHeaderLinks` and `EuiHeaderLink` to Emotion; Removed `$euiHeaderLinksGutterSizes` Sass variables
- Removed `$euiHeaderBackgroundColor` Sass variable; use `$euiColorEmptyShade` instead
- Removed `$euiHeaderChildSize` Sass variable; use `$euiSizeXXL` instead

0 comments on commit 929f25a

Please sign in to comment.