Removed log, removed color transition, changed css classes for case w…

…hen an euiLink is given an onClick, as well as an href and disabled.
elastic · Oct 16, 2019 · 9e5aa1b · 9e5aa1b
1 parent 0a740ec
commit 9e5aa1b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/src-docs/src/views/link/link_disable.js b/src-docs/src/views/link/link_disable.js
@@ -15,7 +15,6 @@ export class LinkDisable extends Component {
   }
 
   toggleLinkDisable = () => {
-    console.log(this.state.disableLink);
     this.setState(prevState => ({ disableLink: !prevState.disableLink }));
   };
 

diff --git a/src/components/link/_link.scss b/src/components/link/_link.scss
@@ -1,6 +1,5 @@
 .euiLink {
   @include euiLink;
-  transition: color $euiAnimSpeedNormal $euiAnimSlightResistance;
 }
 
 $textColors: (

diff --git a/src/components/link/link.tsx b/src/components/link/link.tsx
@@ -73,15 +73,13 @@ const EuiLink = forwardRef<HTMLAnchorElement | HTMLButtonElement, EuiLinkProps>(
     },
     ref
   ) => {
-    const classes = classNames(
-      'euiLink',
-      disabled ? 'euilink-disabled' : colorsToClassNameMap[color],
-      className
-    );
-
     if (href === undefined) {
       const buttonProps = {
-        className: classes,
+        className: classNames(
+          'euiLink',
+          disabled ? 'euilink-disabled' : colorsToClassNameMap[color],
+          className
+        ),
         type,
         onClick,
         disabled,
@@ -98,9 +96,8 @@ const EuiLink = forwardRef<HTMLAnchorElement | HTMLButtonElement, EuiLinkProps>(
     }
 
     const secureRel = getSecureRelForTarget({ href, target, rel });
-
     const anchorProps = {
-      className: classes,
+      className: classNames('euiLink', colorsToClassNameMap[color], className),
       href,
       target,
       rel: secureRel,